preview: keep the words around a complete untrusted wrap - #2445

Written-by: Delivery-1
Owner: Delivery-1

Fixes #2443

What changed

visibleText (core/src/shared/preview.js) unwrapped a complete <untrusted-message …>…</untrusted-message> by keeping only the text between the first opener and the last closer, so every word before and after a mid-line wrap was dropped. It now unwraps each wrap in place — head + inner + tail — and keeps looping until the text stops changing, so a reply that quotes a remote line and then answers it reads as the reply in the sidebar row and in the ⌘K row.

stripFence and every marker rule are untouched, so the two shapes that already worked keep working: a line that is only a complete wrap still reads as just its words, and a broken fragment (kick from="User"> B test 4 >) still loses the marker and keeps the words.

core/workbench-native.js is regenerated in its own commit: the native conversation bundle carries the preview module, so the fence fix left that shipped asset stale and node scripts/build-workbench.mjs --check red. Nothing else moved, and no byte was hand-edited.

Docs-not-needed: the preview module's comment already promises that words which were never part of a marker are kept; this makes the code say what the module already documents, with no new contract, surface or owned path.

Verification at 8c6ee5897c9f669e576c084fcea24bf2fcf108f4

Ran:

cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/preview-fence-words.test.js
# tests 5 / # pass 5 / # fail 0      (base 5e71a07e: # pass 2 / # fail 3)

cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/preview-fence-words.test.js \
  test/fence.test.js test/palette-preview.test.js test/ui-clickthrough.test.js \
  test/details-copy.test.js test/voice-speech.test.js test/inbound-ui.test.js \
  test/held-reply.test.js test/face-row.test.js
# tests 74 / # pass 74 / # fail 0

cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test "test/*.test.js"
# tests 3164 / # pass 3157 / # fail 7

The 7 failures are two test files that cannot pass on this box (test/workbench-client.test.js, test/project-runtime-setup.test.js — /workspace PTY/profile and native-composer refresh cases). They fail with the same names and the same count (32 tests / 25 pass / 7 fail) when the source change is reverted, and they failed the same way on the previous delivery branches.

cd core && npm run lint                                  # 105 warnings, 0 errors
cd core && node scripts/build-client.mjs --check          # exit 0
cd core && node scripts/build-workbench.mjs               # rewrote core/workbench-native.js only
cd core && node scripts/build-workbench.mjs --check       # exit 0
ARCH_DOCS_BASE=5e71a07e037979e4fbb9280d7cf55b1f1da734df node core/scripts/check-arch-docs.mjs
                                            # arch-docs: OK (8 changed file(s))
node scripts/ds-bot-patches.mjs generate && node scripts/ds-bot-patches.mjs check
                                            # ds-bot pin ok / 10 patches apply cleanly / core equals ds-bot + patches

build-workbench needs the packages core/package-lock.json pins (react 18.2.0, shiki, zustand, katex, @deepseek-ai/dsh-client-ui-primitives …), which this box's shared, read-only core/node_modules link does not carry; the run above installed that lock's own set into a scratch prefix, rebuilt, and the --check that follows compares a fresh build against the committed bytes. core/client.js and every other generated file stayed byte-identical.

Not run: npm run build as one command (the two builds ran separately, as above); the two plugin suites and the smoke test (no host or plugin file in this diff).

Files (8, +101 / −17)

• core/src/shared/preview.js — visibleText unwraps in place
• core/test/preview-fence-words.test.js — new, 5 cases (3 red on base)
• core/workbench-native.js — regenerated: the native bundle carries the preview module
• core/client.js — generated bundle
• patches/ds-bot/0008-client-bundle.patch, patches/ds-bot/files/src/shared/preview.js, patches/ds-bot/files/test/preview-fence-words.test.js, patches/ds-bot/files/workbench-native.js — generated from core/

Base: delivery/ai-centric-development-service at 5e71a07e. Branch: HugoXK:delivery1/preview-fence-words. maintainer_can_modify: true.

Checkpoint

{
  "pr": 2445,
  "claim": "Delivery-1",
  "issue": 2443,
  "summary": "visibleText kept only the text between the first untrusted-message opener and the last closer, so every word before and after a mid-line wrap was dropped and a reply that quoted a remote line read as the quote alone in the sidebar and palette rows. It now unwraps each complete wrap in place, head plus inner plus tail, looping until the text stops changing. stripFence and the marker rules are unchanged, so a line that is only a wrap and a broken fragment keep their current reading. core/workbench-native.js is regenerated because that bundle carries the module, and the new five-case test is red three ways on the base tree.",
  "files": [
    "core/src/shared/preview.js",
    "core/test/preview-fence-words.test.js",
    "core/workbench-native.js",
    "core/client.js",
    "patches/ds-bot/0008-client-bundle.patch",
    "patches/ds-bot/files/src/shared/preview.js",
    "patches/ds-bot/files/test/preview-fence-words.test.js",
    "patches/ds-bot/files/workbench-native.js"
  ],
  "checks": { "ran": "cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test \"test/*.test.js\"; node scripts/build-client.mjs --check; node scripts/build-workbench.mjs --check; node scripts/ds-bot-patches.mjs check", "result": "green", "at": "8c6ee5897c9f669e576c084fcea24bf2fcf108f4" },
  "next": "none — ready for review"
}